Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logrus as http request logger #568

Merged
merged 6 commits into from
Nov 1, 2021
Merged

Use logrus as http request logger #568

merged 6 commits into from
Nov 1, 2021

Conversation

stevenvegt
Copy link
Member

@stevenvegt stevenvegt commented Oct 26, 2021 •
edited
Loading

Adds custom logger middleware instead of using echo.RequestLogger because of this issue: labstack/echo#2015

@stevenvegt
Use logrus as http request logger
43fd27e
@stevenvegt
Fix status codes
955e844 
Uses a custom logger middleware since the echo RequestLogger only know how to handle echo.HTTPErrors and logged wrong http status codes.
@stevenvegt
Go fmt
ba2cd66
@stevenvegt
Add tests for logger
cc2ec9f
@stevenvegt
go fmt
6f0f7dc
woutslakhorst
woutslakhorst requested changes Oct 27, 2021
View reviewed changes
core/echo_errors.go Outdated Show resolved Hide resolved
core/echo.go Show resolved Hide resolved
@stevenvegt stevenvegt mentioned this pull request Oct 28, 2021
Closed
3 tasks
@stevenvegt stevenvegt merged commit d067fdd into master Nov 1, 2021
@stevenvegt stevenvegt deleted the echo-logging branch November 1, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutslakhorst woutslakhorst woutslakhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenvegt @woutslakhorst